task-p.5.1

2026-06-30 09:21:34 +07:00
parent 4570495a77
commit e4573ac0c9
28 changed files with 8566 additions and 1875 deletions
--- a/docs/implementation/task-p.5.1-verification-report.md
+++ b/docs/implementation/task-p.5.1-verification-report.md
@@ -0,0 +1,124 @@
+# Task P.5.1 Verification Report
+
+## Scope
+
+This report verifies implementation work for
+[task-p.5.1.md](/C:/Users/mtpphtaps/Documents/gitea/alla-allaos-fullstack/plans/task-p.5.1.md).
+
+Verification focus:
+
+- metadata separation compile safety
+- duplicate workflow compile safety
+- compare UI compile safety
+- helper test execution
+- migration execution
+- build and audit regression checks
+
+---
+
+## Commands Run
+
+```bash
+npm exec tsc --noEmit
+npm exec tsx --test src/features/foundation/document-template/server/metadata.test.ts
+npm exec tsx --test src/features/foundation/document-template/server/service.test.ts
+npm run db:generate
+npm run db:migrate
+npm run build
+npm run audit:pdf
+```
+
+---
+
+## Results
+
+### TypeScript
+
+- `npm exec tsc --noEmit` = PASS
+
+### Added tests
+
+- `metadata.test.ts` = PASS
+- `service.test.ts` = PASS
+
+### Migration flow
+
+- `npm run db:generate` = PASS
+- `npm run db:migrate` = PASS
+
+### Build
+
+- `npm run build` = PASS
+
+Residual build status:
+
+- build warning still present from Turbopack trace on
+  [shared.ts](/C:/Users/mtpphtaps/Documents/gitea/alla-allaos-fullstack/src/features/foundation/pdf-audit/server/shared.ts)
+
+### PDF audit regression
+
+- `npm run audit:pdf` = command PASS
+- `audit:pdf` integrity summary = FAIL
+
+Observed blocking audit issue:
+
+- `ACTIVE_VERSION_SCHEMA_DRIFT`
+- current report points to ALLA active product template version not matching its source JSON
+
+Relevant generated artifact:
+
+- [artifacts/pdf-audit/template-version-report.json](/C:/Users/mtpphtaps/Documents/gitea/alla-allaos-fullstack/artifacts/pdf-audit/template-version-report.json)
+
+---
+
+## What Was Verified Successfully
+
+- document template metadata can now be modeled through dedicated `metadata_json`
+- legacy embedded metadata remains readable through compatibility helpers
+- duplicate version label generation works
+- duplicate route was compiled into the app route tree
+- management panel compiles with:
+  - duplicate action
+  - richer compare dialog
+  - stronger validation display
+- migration file generated and applied successfully
+
+---
+
+## What Remains Unverified or Incomplete
+
+- dedicated route-handler tests for validate/publish/activate/rollback/archive/duplicate
+- minimal browser/E2E checks for `/dashboard/crm/settings/templates`
+- full Turbopack warning cleanup
+- clean `audit:pdf` integrity summary for current seeded DB state
+
+---
+
+## Acceptance Status
+
+Acceptance criteria status for this round:
+
+- `schemaJson` clean-path implementation added = PASS
+- compatibility handling for legacy metadata added = PASS
+- duplicate as draft workflow added = PASS
+- compare UI made substantially more usable = PASS
+- stronger template health structure added = PASS
+- helper-level automated tests added = PASS
+- build remains PASS = PASS
+- runtime code no longer imports `scripts/` directly = PASS
+- Turbopack warning resolved = FAIL
+- runtime audit remains fully green = FAIL
+- route tests complete = FAIL
+- minimal E2E workflow complete = FAIL
+
+---
+
+## Verification Conclusion
+
+P.5.1 made meaningful hardening progress and is build-safe, migration-safe, and test-improved.
+
+However, this round does not fully satisfy every acceptance target yet because:
+
+- the Turbopack warning still remains
+- route/E2E coverage is still incomplete
+- current database verification still shows active template schema drift in `audit:pdf`